fix: Correct conditional checks for PSA config existence and Ansible managed comments #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR addresses two related issues in the
add-pod-security-admission-config.yml
task of the RKE2 server role:is false
, which caused an Ansible error. The condition is now correctly evaluated withnot
and| bool
to check the PSA config file's existence.is false
incorrectly. This has been corrected usingnot
and| bool
to ensure that the file is only removed if it contains Ansible managed comments.Which issue(s) this PR fixes:
there is no such issue
Special notes for your reviewer:
Please review the changes to ensure that:
Testing
Tested locally by running the playbook with and without the PSA config file. Verified that the file is only removed when it exists and contains Ansible managed comments.
Release Notes
The following errors were observed